Addon: Cards

Eorzea Time
 
 
 
Language: JP EN FR DE
Version 3.1
New Items
users online
Forum » Windower » General » Addon: Cards
Addon: Cards
 Asura.Nalfey
Offline
Server: Asura
Game: FFXI
user: Nalf
Posts: 133
By Asura.Nalfey 2024-11-24 08:16:52
Link | Quote | Reply
 
New addon Cards to track AFs and P. Cards.

https://github.com/Nalfey/Cards

Cards will look for any AF reforged NQ, +1, +2, +3 that you own or are stored in mog slips and will check how many P.Cards you already have and need to augment them all to +3.


Three commands:
//cards {JOB} #will check for P.Cards on the current character
&
//cardsall {JOB} #will check for P.Cards on all your mules (you need to load the Cards addon at least once on your mule to create a data file)
&
//cardsmats {JOB} #will list all mats needed to the next tier upgrade and tell you how many of those items you alreayd have/need

Examples:

//cards GEO



//cards WHM



//cardsall PUP



//cardsmats WHM



//cardsmats PUP
[+]
 Asura.Erwins
Online
Server: Asura
Game: FFXI
user: Erwins
Posts: 20
By Asura.Erwins 2024-11-24 09:58:37
Link | Quote | Reply
 
Thank you it's a great one ^^
[+]
 Asura.Erwins
Online
Server: Asura
Game: FFXI
user: Erwins
Posts: 20
By Asura.Erwins 2024-11-24 10:25:36
Link | Quote | Reply
 
Could you add a system to see crafts items needed to upgrade too?
[+]
 Bismarck.Vespertaru
Offline
Server: Bismarck
Game: FFXI
user: Vesper84
Posts: 94
By Bismarck.Vespertaru 2024-11-24 10:40:35
Link | Quote | Reply
 
Adding Scales in as well would be a cherry on top
[+]
 Asura.Nalfey
Offline
Server: Asura
Game: FFXI
user: Nalf
Posts: 133
By Asura.Nalfey 2024-11-24 14:41:12
Link | Quote | Reply
 
Asura.Erwins said: »
Could you add a system to see crafts items needed to upgrade too?
&
Bismarck.Vespertaru said: »
Adding Scales in as well would be a cherry on top

Thanks for the feedback,
I've updated the code to add a new command //cardsmats <JOB>

This will list the mats needed to upgrade to the next tier and show you how many you already have:

Example:

//cardsmats WHM



//cardsmats PUP



//cardsmats GEO
[+]
Offline
Posts: 762
By Kaffy 2024-11-24 16:05:44
Link | Quote | Reply
 
excellent work, thank you.
[+]
 Bismarck.Vespertaru
Offline
Server: Bismarck
Game: FFXI
user: Vesper84
Posts: 94
By Bismarck.Vespertaru 2024-11-24 19:27:12
Link | Quote | Reply
 
[+]
necroskull Necro Bump Detected! [43 days between previous and next post]
 Bismarck.Vespertaru
Offline
Server: Bismarck
Game: FFXI
user: Vesper84
Posts: 94
By Bismarck.Vespertaru 2025-01-06 18:34:16
Link | Quote | Reply
 
For Nalfey:

The lua is currently not picking up 5 pieces of gear due to spelling. I believe the NQ/+1/2/3 status affects the overall abbreviation spelling at times.

Brd body and legs

Run Body, hands, feet

Brioso Just. > Brioso Justau. (currently +2)

Brioso Cann > Brioso Cannions (currently +2)

Rune. Coat > Runist Coat (currently +2)

Rune. Mitons > Runist Mitons (currently +2)

Rune. Boots > Runist Bottes (currently +2)

Only wanted to bring this to your attention.

Do want to thank you again for this add-on and the work you put into it.
[+]
Offline
Posts: 84
By Genoxd 2025-01-06 23:46:50
Link | Quote | Reply
 
This seems like a good one to release through windower
[+]
necroskull Necro Bump Detected! [126 days between previous and next post]
 Asura.Nalfey
Offline
Server: Asura
Game: FFXI
user: Nalf
Posts: 133
By Asura.Nalfey 2025-05-12 15:40:37
Link | Quote | Reply
 
Update to version 1.20 GitHub: Cards

Updated the amout of cards needed for each augments based on the May 12th 2025 update:
https://forum.square-enix.com/ffxi/threads/62737





Bismarck.Vespertaru said: »
Only wanted to bring this to your attention.

Apologies Vesper I only just noticed your message ! Thanks a lot for flagging, this has also been added to the the above version update.


Genoxd said: »
This seems like a good one to release through windower

I attempted to add this addon to Windower many months ago, but the devs never bothered to review the code I submitted.
Since then I don't even want to bother with them anymore.
[+]
VIP
Offline
Posts: 907
By Lili 2025-05-12 22:00:51
Link | Quote | Reply
 
Asura.Nalfey said: »
I attempted to add this addon to Windower many months ago, but the devs never bothered to review the code I submitted.
Since then I don't even want to bother with them anymore.

Passive aggressive much?
The answer to this is always the same one: we're all volunteers, we do this in our spare time, the efforts required to keep code quality within windower addons is high and requires time, the lack of spare time means that code reviews aren't always possible.

This is your PR:https://github.com/Windower/Lua/pull/2402
You can see we did look at your code, we did give you feedback, then I personally told you "sorry I no longer have time to take care of this, maybe other devs do", then no one stepped in because we don't have time and frankly putting your addon inside of windower is not such a big priority over other stuff (like keeping up with updates, or fixing bugs of more widely used addons)

You're entitled to be unhappy, just try to be fair about it.
[+]
 Asura.Nalfey
Offline
Server: Asura
Game: FFXI
user: Nalf
Posts: 133
By Asura.Nalfey 2025-05-13 01:11:20
Link | Quote | Reply
 
Lili said: »
we're all volunteers, we do this in our spare time

Yes precisesly, glad that we're on the same page.
Windower devs don't have time to review code and I don't have time to sit arround 6 months for feedback so that other players can enjoy new addons.

That's why I'd rather not deal with Windower anymore as it's a massive bottleneck to innovation, so I decided to part ways and just share addons with people separately.

Nothing personal against you in particular Lili, on the contrary you were the only one who ever replied.
It's just not working for me.

Hope you understand.
[+]
 Shiva.Thorny
Offline
Server: Shiva
Game: FFXI
user: Rairin
Posts: 3187
By Shiva.Thorny 2025-05-13 13:45:00
Link | Quote | Reply
 
Asura.Nalfey said: »
That's why I'd rather not deal with Windower anymore as it's a massive bottleneck to innovation

Your initial PR would have actively broken things for a subset of users, as Lili outlined. It bottlenecks that sort of thing, too.

Your attitude comes off as very much full of yourself and insulting to Windower, when the quality of your work is rather low compared to theirs.
 Asura.Nalfey
Offline
Server: Asura
Game: FFXI
user: Nalf
Posts: 133
By Asura.Nalfey 2025-05-13 15:59:44
Link | Quote | Reply
 
Shiva.Thorny said: »
Your initial PR would have actively broken things for a subset of users

I was initially asked to tap into Findall to avoid duplicating code even though I did not want to do it. It was a mistake and a bad decision from every party, not just me. You're just trying to point at stuff out of context.

I don't claim to be a developer and that's why I was asking for help and feedback from the Windower team. I understand that people have lives and this is volunteer work, it's the same on my end. But letting my PR open for over 6 months with no feedback what so ever is a bit much don't you think ? Would you consider that fair ?

It's this kind of attitude that just pushes people away from joining the windower dev team to help out. Yes you are all gifted coders but it doesn't mean you need to be ***** to people that are not as good as you.

You guys don't have time to help me with what I'm trying to share with everybody on the game, that's fine I understand, we all have priorities. I'm not holding any grudges, I just don't want to waste my time nor yours.

Kindly refrain from spamming this thread with your pointless hatred, if you want to keep talking about it feel free to PM me.
[+]
 Leviathan.Arcon
VIP
Offline
Server: Leviathan
Game: FFXI
user: Zaphor
Posts: 682
By Leviathan.Arcon 2025-05-13 17:51:12
Link | Quote | Reply
 
Sorry to chime in when you wanted this over with, I'm just hoping to diffuse the hostility a bit. Your points are very valid, and we know that we can improve when it comes to code review. Some cases are difficult to handle, this was one of them. Other cases just get forgotten in the midst of a hectic week, and this was one of them as well.

I can't speak for others, some of us were extremely busy lately. Life do be like that. While I, personally, have been rather busy in the last six months as well, I would still have had time to look into it - in my case, I simply forgot. I generally don't go through our backlog, because I *usually* reply with suggestions and then get notified when someone replies back, so if I don't get notified, I don't *usually* have a reason to go back to an open PR. So when I miss it during one stressful work week, it goes under, and I am not disciplined enough to maintain our backlog regularly. This is definitely on me, and something I need to improve on. While it's not your responsibility, I always appreciate people reminding me, or bumping a PR that has been forgotten.

All this said, I'm sorry to see it come to this. If you decide you want to open the PR again, feel free to, I'll look it over. That said, Lili's comments still stand, and we would definitely prefer to have it share code with findAll, since that is a pretty annoying and complex set of functionality, that we really don't want to duplicate. If you just want to discuss this with us, without an open PR, feel free to hit us up on our Discord, or even DM me (here or there). If, however, you plan to just go your own way with this, no worries, no hard feelings, and best of luck with the project. Can always still ask us for advice (again, preferably on Discord, but here would do as well).
[+]
 Shiva.Thorny
Offline
Server: Shiva
Game: FFXI
user: Rairin
Posts: 3187
By Shiva.Thorny 2025-05-13 20:03:13
Link | Quote | Reply
 
Asura.Nalfey said: »
You guys don't have time to help me with what I'm trying to share with everybody on the game, that's fine I understand, we all have priorities. I'm not holding any grudges, I just don't want to waste my time nor yours.
Just to be clear, I am not associated with Windower at all; I don't even use it. I'm commenting as an outsider. Please don't associate my views with them.
 Phoenix.Salmijr
Offline
Server: Phoenix
Game: FFXI
user: Salmijr
Posts: 207
By Phoenix.Salmijr 2025-05-14 06:34:17
Link | Quote | Reply
 
This looks hella useful, as someone who just recently returned to the game. Will be downloading as soon as I get home
[+]
 Bahamut.Daleterrence
Offline
Server: Bahamut
Game: FFXI
user: Dalight
Posts: 15
By Bahamut.Daleterrence 2025-05-14 14:09:19
Link | Quote | Reply
 
I had no idea this existed, genuinely a great idea for an addon! Only suggestion I'd make is having it list all of the commands when you use //cards or //cards help, right now it only tells you about the main function and not the other (fantastic) stuff it can do, regardless, it's definitely going to be a frequently used addon for me, thanks!
[+]
 Asura.Nalfey
Offline
Server: Asura
Game: FFXI
user: Nalf
Posts: 133
By Asura.Nalfey 2025-05-14 16:43:30
Link | Quote | Reply
 
Bahamut.Daleterrence said: »
Only suggestion I'd make is having it list all of the commands when you use //cards or //cards help, right now it only tells you about the main function and not the other (fantastic) stuff it can do

Thanks for the feedback, this has now been added to version v1.21
GitHub: Cards

//cards with no argumeent now displays the list of commands and usage.
Also added a //cardshelp function to display commands and usage as well.
[+]