Warrior is missing 8% crit damage from traits, which changes the results from a few calcs. I added it back in and it's spitting out Blistering Salet R15 for BiS Ukko's Fury set
Thanks. This was fixed in the May 03 version of the code and the
WAR sets I posted to BG Wiki were updated after I applied this fix locally.
Phoenix.Gavroches said:
»Just a public "Thank you" for starting to update the sets
I finished updating the
equipment sets I posted to BG Wiki to include Rank 30 Odyssey equipment and Mastery Rank 7 Hoxne Earring.
When I use the "select all from file" button, the program will not allow me to have Naegling in Main hand. It always puts it as sub and Hep.
I think I'll need more information to debug this. I rarely use the "select all file" button, but there should be no related bugs with it since its only function is to automatically select specific checkboxes for you. If the item exists in your input file, then the corresponding checkboxes all get selected. Naegling should be selected in both main and off-hand when using this button.
Why exactly does this recommend wsd+ gear on 5+ hit h2h ws? Like on the pup and mnk pages. As far as I remember, wsd was *** for most h2h ws, unless something changed in the last few years that I'm unaware of.
Most H2H weapon skills transfer FTP, so multi-attack is usually the strongest stat to stack.
Looking at the
MNK and
PUP gear sets pages I posted, the only sets that stand out as WSD-heavy are "Maru Kala", "Dragon Blow", "Final Heaven", and "Asuran Fists". Asuran fists is already at the 8-hit cap by default, so multi-attack is useless. The others do not transfer FTP, so their damage is front-loaded to their first hit, which makes weapon skill damage the most potent stat to use.
Noticing some weird behavior.
. . .
Looks like there might be some kind of overflow or rounding error when considering DEF down effects (division by 0 somewhere?).
Thanks for the details. I believe the issue was that I never enforced "enemy_defense > 0" in the "actions.py:average_attack_round()" function (for TP simulations). This was handled in the "weaponskill_info.py" file for weapon skills, so weapon skills were unaffected.
For your DRG/SAM example: all of your debuffs would lower the enemy's defense by about 105.7%, down to -83 defense, which would be passed into the functions for TP damage calculations. The 90-91% geomancy potency was coincidentally the threshold to exceed 100% defense lost. After the fix, the "Average Dmg/Attack" for TP phase with your given TP set changes from ~300 damage to ~6800 damage.
I've updated the
GitHub code to fix this issue. Let me know if you find any other bugs.