The lua I'm using for BRD has a section for Instrument for each song type. Is it possible to make a toggle that takes that into account and allows me to toggle between Gjallarhorn for each song type and Miracle Cheer? i.e: If it's a short fight, I hit the toggle, and get Ghorn buffs, if it's longer (like Ody C), I hit the toggle and get Miracle instead of Ghorn?
Anything is possible, but without seeing your lua and its specifics, hard to advise: if you post it here maybe we can help. Do you know who's lua you are using? Basically you will want to find the logic, add a keybind, and implement an override of the default logic.
I'm using the Arislan BRD one (Original: Motenten / Modified: Arislan). I think I can just share via PasteBin?
https://pastebin.com/JJTDEtbz
I figured it would be adding a keybind (I just look at how the others are implemented, copy that but change what I need) but I'm not sure if that would do it.
I am not super familiar with Motes based gs, but it looks like you already have potential functionality:
Line 133: (send_command('bind ^` gs c cycle SongMode'))
I took the liberty of playing around here with this for 15mins for fun - let me know if it works: (Free to try) You can ping me on discord too same name, perhaps we can get it working.
https://pastebin.com/ki0xRhnA
Use ^` to toggle into miracle cheer mode (Same key as dummy songs). You need to update sets.midcast.SongMiracleCheer line 414 with any relevant gear. (I dont play bard cant really test any of this)
FYI details of what I think needed to be done:
I added miracle cheer to line 73:
state.SongMode = M{['description']='Song Mode', 'None', 'Placeholder', 'MiracleCheer'}
Then adding to near line 1008:
elseif state.SongMode.value == 'MiracleCheer' then
return 'SongMiracleCheer'
And then setting up the invoked set around line 413: (edit as needed)
sets.midcast.SongMiracleCheer = set_combine(sets.midcast.SongEnhancing, {range=info.MiracleCheer})
As well as putting at line 124:
info.MiracleCheer = 'Miracle Cheer'
Not sure if the precast set was needed, as I don't see logic but added that too.