|
Battlemod v2
Shiva.Shazam
Server: Shiva
Game: FFXI
Posts: 2
By Shiva.Shazam 2013-04-19 03:58:39
I got an Error while Logging into FF, so i leave you a Picture there.
Server: Asura
Game: FFXI
Posts: 670
By Asura.Izilder 2013-04-19 05:48:46
since last push im getting
invalid number of method arguments expected 2 got 3 on any spell done on self
also just had a Lost Soul cast ice spikes on self which caused same error , in fact seems all mobs self buffs do the same
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6379
By Lakshmi.Byrth 2013-04-19 06:14:21
Quote: Additional Feature:
* The "__damage" colors don't do anything, but have been left in the settings file for potential future uses.
* Potentially add a delay.
* Make it display the amount of ammunition remaining when you fire a shot.
* Somehow add a filter for monsters that you are currently fighting?
* Add a filter to change the color when debuffs vs. buffs wear off
* Filter for item usage
* Filter for "gains the effects of" messages
* Need to incorporate Resist vs. Normal AoE buff pools when there's a mix.
* Need to condense "wears off" messages.
* I need to try and integrate SE's chat filters into this.
LuaCore or Hook related problems:
* Using //bm colortest and then expanding your chat log on small window size clients (640x480) can cause crashes? (Your guess is as good as mine)
* Many usable weapons do not show up due to next() corruption issues? -- work-around implemented (thanks Arcon!)
* Fomor TP move ready messages are not displayed because I cannot distinguish humanoids from non-humanoids without more information, so I don't know which ability table to pull from.
Battlemod problems:
* Fix the pet-identification algorithm (somehow) - May be fixed
* Re-generating the settings files is not working - Should be fixed
* Healing magic filter is not be working properly. - May be fixed
* Condense settings don't really work when they're turned to false. (Consider reinstating the colorful setting).
* Fix the grammar. (Low priority because it would be very hard to do.)
Unreplicated bugs:
* Mining/Harvesting may be affected in some way?
- Okay, I fixed the above error and Suji/Arcon fought the items bug with me. Arcon landed the killing blow.
- Fomor TP moves are difficult. Humanoid monsters seem to pull from the jobabilities.xml player ability table, while other types of monsters pull from mabils.xml. The indices overlap and I have no way to differentiate them when they're "readying" the move, but I think fomor TP moves should show properly when they're actually using the move now.
- The Spikes/Retaliation/Counter filtering problem should be fixed, as should the Additional Effect/Spikes/Retaliation/Counter damage color problem.
- The "2 expected" error is fixed. I don't know why, but it doesn't like me to use :gsub inside of add_to_chat.
- Blood Weapon was giving duplicate chat log messages, but I couldn't see anything wrong with its value necessarily. I fixed the duplicate problem. This was probably also Drain Samba's problem.
- The red "target is out of range" message will no longer be generated by battlemod because I can't block the normal message without also blocking a bunch of system messages that I can't generate.
If you do not see your problem on the list, I think I've fixed it and need to be told about it again.
Edit: Looks like I only really have one more bug to squash (that I know of and can squash) before I go back to adding features!
By Yinx 2013-04-19 07:58:05
Just saw this when someone else used an item.
X uses a dream hat +1.
X uses a dream hat +1.
X obtains a dream hat +1.
Lakshmi.Jimmothy
Server: Lakshmi
Game: FFXI
Posts: 258
By Lakshmi.Jimmothy 2013-04-19 07:59:23
I got an Error while Logging into FF, so i leave you a Picture there.

Having this exact issue with battlemod, and my dynamishelper wont load, gives me a bunch of lines that say missing files from the playonline folders.
Diabolos.Yugl
Server: Diabolos
Game: FFXI
Posts: 138
By Diabolos.Yugl 2013-04-19 08:03:21
He may have fixed, but if you look at line 73, you'll notice an extra parenthesis.
"items = parse_resources(itemsGFile:readlines())}"
Remove the extra parenthesis.
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6379
By Lakshmi.Byrth 2013-04-19 08:04:02
Jimmothy, you need to re-run launcher.
Yinx: A new challenger emerges. I know what's wrong with this but it's going to take a resources update and battlemod update to fix. I'll probably do it tonight or tomorrow morning.
Edit: Actually, I lied. Yinx, that should be fixed now. You should just need to re-run launcher.
[+]
Lakshmi.Jimmothy
Server: Lakshmi
Game: FFXI
Posts: 258
By Lakshmi.Jimmothy 2013-04-19 08:33:16
Jimmothy, you need to re-run launcher.
Yinx: A new challenger emerges. I know what's wrong with this but it's going to take a resources update and battlemod update to fix. I'll probably do it tonight or tomorrow morning.
Edit: Actually, I lied. Yinx, that should be fixed now. You should just need to re-run launcher.
Okay i'll try it when I get home from work. Any idea about about dynamis helper? it's doing what battlemod used to do before it started this line 73 thing.
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6379
By Lakshmi.Byrth 2013-04-19 08:42:15
Dynamis Helper isn't my project, so I don't know anything about it. I recommend this thread:
http://www.ffxiah.com/forum/topic/37747/dynamis-helper/
Server: Shiva
Game: FFXI
Posts: 39
By Shiva.Ithorien 2013-04-19 10:19:59
Byrth, I noticed something last night while fighting Mictlantecuhtli in Aby-Tahrongi. As you know he absorbs melee while not casting and vice versa. There were a couple times I didn't turn at the right time at which he absorbed my damage, but in chat log it simply showed as:
Ithorien → Mictlantecuhtli
The arrow was blue indicating a heal, but there was no number present in the front as opposed to the regular
Ithorien 386 → Mictlantecuhtli
I didn't take a screenshot but I'm sure you know what I mean. I didn't see this on your list but if it's something you're already aware of disregard.
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6379
By Lakshmi.Byrth 2013-04-19 10:48:34
I didn't realize that was happening, but it should be easy to check out later. Thanks!
I added a filter for "items" and "uses" messages that will block item-specific messages.
Edit: I think that I just pushed a fix for the Fomor WSs. It'll either fix Fomor WSs or (with my luck), break monster WSs entirely and I'll get people reporting that monster WSs don't show up for two days despite patching it 15 minutes after I'm first told.
Server: Asura
Game: FFXI
Posts: 670
By Asura.Izilder 2013-04-19 13:13:24
mob moves in aby generating error 127
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6379
By Lakshmi.Byrth 2013-04-19 13:17:45
Pushed a fix for that, but I would have expected it to occur when you use TP moves and not the monster. Actually, I never would have expected it to occur. Tell me who shows up with blank missing TP moves now I guess.
By Yinx 2013-04-19 15:24:14
One fixed, another occured. :>
While fighting Mictlantecuhtli, absorbed dmg on melee attacks isn't displayed correctly.
[Yinx] -> Mictlantecuhtli
It's working on WS thoough.
Bismarck.Helel
Server: Bismarck
Game: FFXI
Posts: 1335
By Bismarck.Helel 2013-04-19 15:27:10
I believe the fomor tp moves do display 'after' the readying message. Definitely not a big issue, just a warning to anyone doing SSR2 to watch out for aegis schism.
This add-on is great for KC RNG btw. I can actually see my WS damage now before the club damage hides it.
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6379
By Lakshmi.Byrth 2013-04-19 15:44:28
That should be fixed now, Helel.
The Mictl thing is also known and I can fix it when I get home tonight. I just don't handle absorb messages for category 1/2 (melee/ranged - and I don't know what they are, so I can't do it from here.) I think it's probably #263, but I can't be sure until I get home and go hit him.
Bismarck.Helel
Server: Bismarck
Game: FFXI
Posts: 1335
By Bismarck.Helel 2013-04-19 15:47:10
That should be fixed now, Helel.
The Mictl thing is also known and I can fix it when I get home tonight. I just don't handle absorb messages for category 1/2 (melee/ranged - and I don't know what they are, so I can't do it from here.) I think it's probably #263, but I can't be sure until I get home and go hit him.
Oh, okay great. I haven't fought any since yesterday. Appreciate it.
Quetzalcoatl.Morari
Server: Quetzalcoatl
Game: FFXI
Posts: 27
By Quetzalcoatl.Morari 2013-04-19 19:36:24
Just a quick question, mostly out of curiosity really...
With BattleMod loaded, whenever I check a mob, it gives a numerical value for its level. Now, is this because that info is sent to me in some fashion or does battlemod pull from some database to get that data?
Phoenix.Suji
Server: Phoenix
Game: FFXI
Posts: 962
By Phoenix.Suji 2013-04-19 19:39:01
Quetzalcoatl.Morari said: »Just a quick question, mostly out of curiosity really...
With BattleMod loaded, whenever I check a mob, it gives a numerical value for its level. Now, is this because that info is sent to me in some fashion or does battlemod pull from some database to get that data? It gets sent to the client-- just isn't ordinarily displayed.
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6379
By Lakshmi.Byrth 2013-04-19 21:06:58
Absorbs should work now.
Also, yeah. It's sent normally but not displayed normally.
Server: Shiva
Game: FFXI
Posts: 27982
By Shiva.Spathaian 2013-04-19 23:42:23
When there's nothing to Dispel it is coming up as a resist, and apparently twice.
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6379
By Lakshmi.Byrth 2013-04-20 06:38:32
Resists and No Effect messages should show up as their respective values now, as well as Immunobreaks.
[+]
Quetzalcoatl.Lanien
Server: Quetzalcoatl
Game: FFXI
Posts: 21
By Quetzalcoatl.Lanien 2013-04-20 19:51:32
I don't know if this has already been mentioned, but singling out WS damage from melee damage would be nice.
I'd love to see what my party members WS numbers are like without having to see ALL of their melee hits, especially in small groups like Salvage where we're skillchaining.
Also, this might just be the effect of me being slightly drunk and tired but are those new filters not added into the updated filters.xml file? Or not added at all yet? I don't see 'em.
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6379
By Lakshmi.Byrth 2013-04-20 20:11:40
That's one of the original filters. Turn the "melee" filter to true.
Shiva.Paulu
Server: Shiva
Game: FFXI
Posts: 779
By Shiva.Paulu 2013-04-21 10:00:07
So I noticed today I was receiving debug messages. If I try to use an ability that isn't ready. (I'm a compulsive hasso spammer between mobs don't judge me). I would also see debug messages if I tried to ws when I was unable to see targets (Cleave-style mob spinning and whatnot).
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6379
By Lakshmi.Byrth 2013-04-21 10:09:59
Yeah, sorry. I uploaded a copy this morning that had debug enabled. It's fixed now.
Server: Fenrir
Game: FFXI
Posts: 3012
By Fenrir.Leoheart 2013-04-21 10:20:39
Kinda found this in besieged lol
Not sure if it's been addressed or it's something on my end:
edit: When I use a Megalixir*
Lakshmi.Jimmothy
Server: Lakshmi
Game: FFXI
Posts: 258
By Lakshmi.Jimmothy 2013-04-21 23:51:36
Getting this error when trying to load both battlemod and dynahelper (i know that ones not yours but it's the exact same error)
Lua error C:\Program Files (x86)\Windower4\\addons\libs\colors.lua:13: attempt to index a nil value.
EDIT: Nevermind, I completely uninstalled windower4 again, deleted all the files the uninstall didn't and then reinstalled and reloaded all my settings and everything works perfect now.
By chiquitito 2013-04-23 14:01:51
Got the following 2 lines during Ig-Alima fight. Believe was a MNK JA, but not sure with everything that was goin on.
event_action lua:183 attempt to concatenate local 'effect_val' (a nil value)
event_action lua:183 attempt to concatenate local 'ability' (a nil value)
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6379
By Lakshmi.Byrth 2013-04-23 14:06:44
If I was a betting man, I would bet that error was caused by someone other than you using Gauge. I can't guess what message that would send, so I will have to check later.
OH GOD! I CAN SEE FOREVER! - You need to change your filters (battlemod/data/filters/filter-<job>.xml). I have intentionally set it up so that the default filters are all-off because I figure it's worse if you miss messages that you were expecting than if you see things you weren't expecting. See the "Settings Files" part of the Readme below.
In anticipation of a lot of people having problems with this, I have made this thread to answer questions. First, here is the Readme file:
Readme said: Author: Byrth
Version: 2.0
Date: 13/4/13
Battlemod, packet version
Abbreviation: //bm
Commands:
* help - shows a menu of these commands in game
* colortest - Shows the 509 possible colors for use with the settings file
* reload - Reloads the settings file
* unload - unloads Battlemod
* condensebuffs - Condenses Area of Effect buffs, Default = True
* condensebattle - Condenses battle logs according to your settings file, Default = True
* cancelmulti - Cancles multiple consecutive identical lines, Default = True
* oxford - Toggle use of oxford comma, Default = True
* commamode - Toggle comma-only mode, Default = False
* targetnumber - Toggle target number display, Default = True
* colorful - Colors the output by alliance member, Default = True
Purpose: To allow chat log customization.
Installation Instructions (from the Windower 4 Launcher):
* 1 Start your copy of Windower 4 and select the "Addons" menu up top in the Launcher.
* 2 Click the icon next to "Battlemod"
* 3 Log in to the game!
* 4 Alter the settings as you wish. ("//bm colortest" will let you see the color options and )
* 5 If you have changed the settings, you can use "//bm reload" to load them in game.
Settings Files:
The settings files for battlemod are composed of 3 to 25 xml files (depending on how much you like unique filters). XML files can be opened with Notepad, edited, and saved. If you are going to "Save As..." an xml from Notepad, be sure to change "Text Documents (.txt)" to "All Files" file type and make sure the file ends in ".xml"
* data/settings.xml - contains basic flags that control the features of the program.
* data/colors.xml - contains all the color codes relevant to the program, which can be adjusted using colors from the colortext command.
* filters/filters.xml - contains the chat filter settings and is explained more thoroughly therein.
* filters/filters-<job>.xml - Several examples are provided, but these are specific filter files that will load for your individual jobs. You can use this to, for instance, make sure your healing jobs can always see damage taken (by unfiltering the <monsters></monsters> section or make sure your zerg jobs don't have to see the entire alliance's damage spam.
Known Issues:
* Counters, Spikes, and Retaliations are the wrong color for some reason.
* The "__damage" colors don't do anything, but have been left in the settings file for potential future uses.
* Using //bm colortest and then expanding your chat log on small window size clients (640x480) can cause crashes. (Your guess is as good as mine)
* AoE buffs only use the first message response, so if it has no effect on the user then it will appear to have no effect on everyone even if it did.
* The settings files are much larger and more complicated than v1. (Sorry, it's because there's more options)
* This plugin bypasses and renders invalid all chat filters other than its own.
Secondly, Battlemod attempts to re-create every interaction message (event_action) and other battle messages (event_action_message). I have been testing it for two weeks, but I have not done everything and (more importantly) I do not use every job. There are three major probable and unknown errors:
1) Battle text is showing up as say-color. - This means that I did not see the message while testing battlemod.
2) I'm blocking a message that should display. - This could be anything from your Time remaining in Dynamis to your Mandau's Enpoison effect.
3) I'm failing to display something properly. - If you see ${field} in your text, if something is missing, if the spacing is weird, etc.
If you find an error, please tell me:
1) What the exact text was (if possible)
2) What color it should be (Grey, Yellow, etc.) if the color was wrong
3) If there's an error in the console, the exact line number and message.
These add_to_chat colors are blocked by battlemod:
These ones are blocked:
20,21,22,23,24,25,26,28,29,31,32,33,35,36,40,41,42,43,44,50,51,52,56,57,59,60,69,64,65,67,69,81,85,90,91,100,101,102,104,105,106,110,111,112,114,122,163,164,168,171,175,177,183,185,186,191
|
|